Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dmflags menu #329

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add dmflags menu #329

wants to merge 9 commits into from

Conversation

Bishop-333
Copy link
Contributor

No description provided.

@NeonKnightOA

This comment was marked as abuse.

@The-Gig
Copy link
Contributor

The-Gig commented Apr 4, 2024

NK, maybe you might provide him a screenshot of the point where you would want the link, within the Create server page?

Furthermore, IIRC you were planning to move some settings to an Advanced page. Do you think it's better Create>Dmflags or Create>Advanced>Dmflags?

@NeonKnightOA

This comment was marked as abuse.

@The-Gig
Copy link
Contributor

The-Gig commented Apr 4, 2024

I did mean to put dmflags in their own page (or maybe a two-columns layout for having Videoflags too?), also because more options may be added in the past (there is already the fast water movement one)... My question was about reaching it directly or passing through Advanced page first.
I meant whether you planned to place the link to access dmflags page directly into "Create server" page or inside the (to be created, AFAIK) "Advanced" page? In the first way, it would require one click less to reach dmflags page, but would take up one more space in Create server page.

I'm not sure I found the right words to express it.

By the way, how should the link "case" look? DMFLAGS, dmflags, DMflags, DMFlags, Dmflags?

@NeonKnightOA

This comment was marked as abuse.

@NeonKnightOA NeonKnightOA force-pushed the dmflags branch 3 times, most recently from 4bbce77 to 8e02b0d Compare April 5, 2024 22:17
@NeonKnightOA

This comment was marked as abuse.

@NeonKnightOA
Copy link
Contributor

NeonKnightOA commented Apr 7, 2024

I found out why I can't compile your code, and it's because ui_dmflags.c wasn't included in the Windows scripts.

However, it still doesn't compile. So here's an updated patch adapted to the latest gamecode. It diffs OpenArena/gamecode with your changes. Maybe you can figure out the error.

@leilei-
Copy link
Member

leilei- commented Apr 10, 2024

even if the gamecode got reverted in a fit, I am not opposed to having a dmflags menu (or any advanced subpages for server creation), so I am keeping this pull open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants