Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple comments from getting posted #40

Open
astrofrog opened this issue Nov 22, 2018 · 2 comments
Open

Prevent multiple comments from getting posted #40

astrofrog opened this issue Nov 22, 2018 · 2 comments

Comments

@astrofrog
Copy link
Collaborator

Recently, there has been some kind of race condition where the comment from the bot doesn't get posted fast enough, and when creating a PR with e.g. 10 labels, 11 events get fired and each results in a new comment getting posted. We should investigate further.

See also astropy/astropy-bot#95
@astrofrog astrofrog mentioned this issue Nov 22, 2018
Closed
@pllim
Copy link
Contributor

pllim commented Dec 4, 2018

Now that bot do the status stuff, this is no longer an issue.

@pllim pllim closed this as completed Dec 4, 2018
@astrofrog
Copy link
Collaborator Author

There is still an option in baldrick to post comments, so I'm going to re-open this for now since it's still an underlying issue for baldrick even if not for astropy-bot

@astrofrog astrofrog reopened this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrofrog @pllim