Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Astrobot seems to repeat its messages #95

Closed
mhvk opened this issue Nov 14, 2018 · 6 comments
Closed

Astrobot seems to repeat its messages #95

mhvk opened this issue Nov 14, 2018 · 6 comments
Labels

Comments

@mhvk
Copy link

mhvk commented Nov 14, 2018

I got three at astropy/astropy#8128

@mhvk mhvk added the bug label Nov 14, 2018
@pllim
Copy link
Member

pllim commented Nov 14, 2018

Yes, it is a known issue and probably some bug upstream on GitHub. @astrofrog tried adding a time.sleep but it didn't work.

@astrofrog
Copy link
Member

It's more of a race condition than a bug - we just handle all the events from GitHub faster than GitHub can post the comment.

@mhvk
Copy link
Author

mhvk commented Nov 16, 2018

Yes, github seems to have become much slower than it used to. I hope it is not meant just to get people to sign up for paid service.

@astrofrog
Copy link
Member

astrofrog commented Nov 22, 2018

This should now be fixed since I've changed astropy-bot to post individual status checks rather than a comment, so this shouldn't happen anymore in astropy-bot (but opening OpenAstronomy/baldrick#40 as a general baldrick issue)

@pllim
Copy link
Member

pllim commented Nov 22, 2018

@astrofrog , does the README need to be updated to document how to install the bot as "status check"? Or is this all being done under the hood over at Baldrick?

@astrofrog
Copy link
Member

@pllim - that should be described in https://baldrick.readthedocs.io/en/latest/plugins.html - but feel free to open a PR for the README here if you think we can make things like that clearer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants