Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable auto installation ID lookup #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 9, 2018

Fix #46 . Do you even want to go this route before I have to worry about updating the rest of tests?

  • Fix test failures
  • Add change log

@astrofrog
Copy link
Collaborator

I guess one issue is that it would be nice to also be able to use some parts of the GitHub API without authentication. I wonder whether we should specifically say that installation='auto' or installation=True to mean automatically get the ID? @Cadair do you have any thoughts?

@Cadair
Copy link
Member

Cadair commented Aug 23, 2019

I think this looks fine to me.

This doesn't stop us from creating a repo handler for a non-installed repo and doing things that aren't authenticated right?

@pllim
Copy link
Contributor Author

pllim commented Aug 23, 2019

I don't even remember this one anymore... 😬 Let me know if I should revisit this, or we can just close this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better way to provide installation ID when running bot locally
3 participants