Skip to content

BUG: fix invalid parsing for default test_groups='' #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

neutrinoceros
Copy link
Contributor

Following failed downstream integration in OpenAstronomy/github-actions-workflows#286, follow up to #21
(redo #22)

@neutrinoceros neutrinoceros marked this pull request as draft June 23, 2025 10:36
@neutrinoceros neutrinoceros changed the title TST: add a job without dependency groups BUG: fix invalid parsing for default test_extras='' Jun 23, 2025
@neutrinoceros neutrinoceros changed the title BUG: fix invalid parsing for default test_extras='' BUG: fix invalid parsing for default test_groups='' Jun 23, 2025
@neutrinoceros
Copy link
Contributor Author

The bug was that my parsing command tranformed an empty string into an invalid set of arguments --group (missing value), instead of the correct '', which is equivalent to $group_flags being left unset.

@Cadair Cadair merged commit 9a4b2bd into OpenAstronomy:main Jun 23, 2025
3 checks passed
@neutrinoceros neutrinoceros deleted the bug/pep735-support branch June 23, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants