Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECSC Geramy #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ECSC Geramy #12

wants to merge 2 commits into from

Conversation

Nils1729
Copy link

@Nils1729 Nils1729 commented Oct 18, 2024 •
edited
Loading

This is a reduced version of the changes Team Geramy ran for ECSC2024.

  • Fixes errors in escape on structured data in the CLI
  • Removes the flag queue and changes some implementation in flags.py.
    • Deduplication cache has been rewritten (I didn't understand the invariants of the previous ones)
    • Deduplication queries are batched now, we do not run one query per flag anymore.

@Nils1729
Stringify data before sending it to escape
82d6b8f 
For us, the CLI constantly printed errors and terminated because
`escape` only accepts strings, bytes etc, not JSON-like dicts.
@Nils1729
Remove flag queue
35db0ff 
Also rewrite quite a lot of `flags.py`. This almost but not quite the setup
we ran for ECSC2024. I removed some indirections we used to handle the new
RESUBMIT flag status specific to that event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nils1729