Resolve PR comments

OpenBAS-Platform · Sep 9, 2024 · ec87b0e · ec87b0e
1 parent 2835f6c
commit ec87b0e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/openbas-front/src/admin/components/injects/InjectTestPopover.tsx b/openbas-front/src/admin/components/injects/InjectTestPopover.tsx
@@ -60,7 +60,7 @@ const InjectTestPopover: FunctionComponent<Props> = ({
   const submitTest = () => {
     testInject(injectTestStatus.inject_id!).then((result: { data: InjectTestStatus }) => {
       onTest?.(result.data);
-      MESSAGING$.notifySuccess(t(`Test for ${injectTestStatus.inject_title} has been sent`));
+      MESSAGING$.notifySuccess(t('Test for inject {injectTitle} has been sent', { injectTitle: injectTestStatus.inject_title }));
       return result;
     });
     handleCloseTest();

diff --git a/openbas-front/src/admin/components/injects/InjectTestReplayAll.tsx b/openbas-front/src/admin/components/injects/InjectTestReplayAll.tsx
@@ -32,7 +32,7 @@ const ImportUploaderMapper: FunctionComponent<Props> = ({
   const handleSubmitAllTest = () => {
     bulkTestInjects(injectIds!).then((result: { data: InjectTestStatus[] }) => {
       onTest?.(result.data);
-      MESSAGING$.notifySuccess(t(`${injectIds?.length} test(s) sent`));
+      MESSAGING$.notifySuccess(t('{testNumber} test(s) sent', { testNumber: injectIds?.length }));
       return result;
     });
     handleCloseAllTest();

diff --git a/openbas-front/src/utils/Localization.js b/openbas-front/src/utils/Localization.js
@@ -1316,9 +1316,8 @@ const i18n = {
       'Test status': 'Statut du test',
       'Inject test has been sent, you can view test logs details on {itsDedicatedPage}.': 'Le test du stimuli a été envoyé, vous pouvez visualiser les logs de test sur {itsDedicatedPage}.',
       'its dedicated page': 'sa page dédiée',
-      'Test for': 'Le test pour le stimuli',
-      'has been sent': 'a été envoyé',
-      'test(s) sent': 'test(s) envoyé(s)',
+      'Test for inject {injectTitle} has been sent': 'Le test pour le stimuli {injectTitle} a été envoyé',
+      '{testNumber} test(s) sent': '{testNumber} test(s) envoyé(s)',
       'Value that signifies that all teams are targeted. A regex can be used.': 'Valeur indiquant que l\'injecteur s\'applique à toutes les équipes. Il est possible d\'utiliser une expression régulière.',
       'Fit view': 'Ajuster la vue',
       'Increase time interval': 'Augmenter l\'intervalle de temps',
@@ -2688,6 +2687,8 @@ const i18n = {
         'Do you want to test these {count} injects?',
       'Inject test has been sent, you can view test logs details on {itsDedicatedPage}.': 'Inject test has been sent, you can view test logs details on {itsDedicatedPage}.',
       'its dedicated page': 'its dedicated page',
+      '{testNumber} test(s) sent': '{testNumber} test(s) sent',
+      'Test for {injectTitle} has been sent': 'Test for {injectTitle} has been sent',
       // Platform Banner
       'IMAP service is not responding, your injectors may be impacted.': 'IMAP service is not responding, your injectors may be impacted.',
       'Executor Caldera is not responding, your exercises may be impacted.': 'Executor Caldera is not responding, your exercises may be impacted.',