Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix missing fields in injectForm and improve ui #2196

Merged

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jan 13, 2025

Proposed changes

  • Fix missing description and tags fields on injectForm (refact changed reference of tagField.js to TagField.tsx... and the behavior is not the same) :
    image

  • Improve ui for targets assets :
    image

  • Fix internal error for sort by tags on assetgroups list
    image

  • Improve ui for Humans Reponse : validation needed button -: Center button
    image

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 changed the base branch from master to release/1.11.0 January 13, 2025 08:00
@savacano28 savacano28 self-assigned this Jan 13, 2025
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.54%. Comparing base (4d117b9) to head (7f99397).
Report is 1 commits behind head on release/1.11.0.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2196      +/-   ##
====================================================
- Coverage             32.66%   32.54%   -0.13%     
+ Complexity             1511     1508       -3     
====================================================
  Files                   581      581              
  Lines                 18026    18026              
  Branches               1156     1156              
====================================================
- Hits                   5889     5867      -22     
- Misses                11874    11896      +22     
  Partials                263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review January 13, 2025 08:59
@savacano28 savacano28 force-pushed the bugfix/fix-missing-inject-description-inject-form branch from 1865894 to 1e80804 Compare January 13, 2025 09:01
@savacano28 savacano28 requested a review from MarineLeM January 13, 2025 10:15
@savacano28 savacano28 merged commit dd5b145 into release/1.11.0 Jan 13, 2025
6 checks passed
@savacano28 savacano28 deleted the bugfix/fix-missing-inject-description-inject-form branch January 13, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants