-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix missing fields in injectForm and improve ui #2196
Merged
savacano28
merged 7 commits into
release/1.11.0
from
bugfix/fix-missing-inject-description-inject-form
Jan 13, 2025
Merged
[frontend] Fix missing fields in injectForm and improve ui #2196
savacano28
merged 7 commits into
release/1.11.0
from
bugfix/fix-missing-inject-description-inject-form
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2196 +/- ##
====================================================
- Coverage 32.66% 32.54% -0.13%
+ Complexity 1511 1508 -3
====================================================
Files 581 581
Lines 18026 18026
Branches 1156 1156
====================================================
- Hits 5889 5867 -22
- Misses 11874 11896 +22
Partials 263 263 ☔ View full report in Codecov by Sentry. |
savacano28
force-pushed
the
bugfix/fix-missing-inject-description-inject-form
branch
from
January 13, 2025 09:01
1865894
to
1e80804
Compare
MarineLeM
reviewed
Jan 13, 2025
openbas-front/src/admin/components/common/injects/UpdateInjectDetails.js
Show resolved
Hide resolved
MarineLeM
approved these changes
Jan 13, 2025
savacano28
deleted the
bugfix/fix-missing-inject-description-inject-form
branch
January 13, 2025 11:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix missing description and tags fields on injectForm (refact changed reference of tagField.js to TagField.tsx... and the behavior is not the same) :
Improve ui for targets assets :
Fix internal error for sort by tags on assetgroups list
Improve ui for Humans Reponse : validation needed button -: Center button
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...