Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Add tests for ExportButton component (#2285) #2218

Draft
wants to merge 4 commits into
base: release/current
Choose a base branch
from
Draft

[frontend] Add tests for ExportButton component (#2285) #2218

wants to merge 4 commits into from
+158 −10

Conversation

antoinemzs
Copy link
Contributor

@antoinemzs antoinemzs commented Jan 15, 2025 •
edited
Loading

Proposed changes

  • Adding tests for the ExportButton component

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@antoinemzs antoinemzs changed the base branch from master to issue/1489_test_export_xls January 15, 2025 14:55
@antoinemzs antoinemzs added filigran team use to identify PR from the Filigran team do not merge Do not merge this PR until this tag will be removed labels Jan 15, 2025
@antoinemzs antoinemzs linked an issue Jan 16, 2025 that may be closed by this pull request
[ Unit testing - simulation scope ] - import/export of a simulation (JSON) #1489
Closed
@antoinemzs antoinemzs force-pushed the issue/1489_test_export_xls branch 2 times, most recently from f5abfe2 to 1e53864 Compare January 20, 2025 14:31
Base automatically changed from issue/1489_test_export_xls to release/current January 21, 2025 13:53
@antoinemzs
fail to parse source
ff9187e 
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs
maybe almost working ??
753782d 
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs force-pushed the issue/1489_test_xls_components branch from 0574be6 to 753782d Compare January 21, 2025 16:47
@antoinemzs antoinemzs removed a link to an issue Jan 22, 2025
[ Unit testing - simulation scope ] - import/export of a simulation (JSON) #1489
Closed
@antoinemzs antoinemzs linked an issue Jan 22, 2025 that may be closed by this pull request
[ Unit testing - simulation scope ] - import/export of a simulation (XLS) #2285
Open
@antoinemzs antoinemzs mentioned this pull request Jan 22, 2025
Open
@antoinemzs antoinemzs changed the title [frontend] Add tests for ExportButton component (#1489) [frontend] Add tests for ExportButton component (#2285) Jan 22, 2025
@antoinemzs
progress
c93a663 
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs
finally
592d408 
Signed-off-by: Antoine MAZEAS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Do not merge this PR until this tag will be removed filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Unit testing - simulation scope ] - import/export of a simulation (XLS)
1 participant
@antoinemzs