Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Remove grey sections with 'coming soon' to be more align with what's actually available #2297

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

RomuDeuxfois
Copy link
Member

Proposed changes

  • Refacto the entire left bar component to multiples components

Related issues

@RomuDeuxfois RomuDeuxfois changed the base branch from master to release/current January 24, 2025 18:42
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.28%. Comparing base (29e28d5) to head (a30b6a1).
Report is 2 commits behind head on release/current.

Files with missing lines Patch % Lines
...s/rest/payload/service/PayloadCreationService.java 20.00% 4 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2297      +/-   ##
=====================================================
- Coverage              36.28%   36.28%   -0.01%     
- Complexity              1656     1657       +1     
=====================================================
  Files                    589      589              
  Lines                  18066    18069       +3     
  Branches                1176     1177       +1     
=====================================================
+ Hits                    6555     6556       +1     
- Misses                 11185    11187       +2     
  Partials                 326      326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarineLeM MarineLeM self-requested a review January 27, 2025 07:45
@MarineLeM
Copy link
Contributor

I believe you also need to update the OBAS documentation, as some sections are linked to the page you removed :
sample : https://docs.openbas.io/latest/usage/skills/

@RomuDeuxfois
Copy link
Member Author

I believe you also need to update the OBAS documentation, as some sections are linked to the page you removed : sample : https://docs.openbas.io/latest/usage/skills/

Thanks for pointing that out ! It's done, the doc need to be redeployed.

@RomuDeuxfois
Copy link
Member Author

@MarineLeM Ready for a second round

<>
<ListItemText
primary={t(item.label)}
slotProps={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RomuDeuxfois RomuDeuxfois merged commit d8abbd2 into release/current Jan 30, 2025
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/2289 branch January 30, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove grey sections with 'coming soon' to be more align with what's actually available
2 participants