Rework executor system #2303
Draft
Rework executor system #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomuDeuxfois
force-pushed
the
issue/2220-tmp
branch
from
973055e to
7f5a549
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #2303 +/- ##
=====================================================
+ Coverage 36.16% 36.33% +0.16%
+ Complexity 1653 1647 -6
=====================================================
Files 589 589
Lines 18066 17965 -101
Branches 1176 1173 -3
=====================================================
- Hits 6533 6527 -6
+ Misses 11207 11104 -103
- Partials 326 334 +8 ☔ View full report in Codecov by Sentry. |
impolitepanda
requested changes
Jan 28, 2025
RomuDeuxfois
force-pushed
the
issue/2220-tmp
branch
from
52a2434 to
1ddaf1f
Compare
heditar
reviewed
Jan 28, 2025
|
|
||
| @Data | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public static class StatusPayloadDocument { |
There was a problem hiding this comment.
should we move that to its own file ?
|
|
||
| @JsonProperty("file_drop_file") | ||
| private Document fileDropFile; | ||
| private StatusPayloadDocument fileDropFile; |
There was a problem hiding this comment.
can we use a builder here ?
| } | ||
| injectStatus.setName(status); | ||
| injectStatus.setTrackingSentDate(Instant.now()); | ||
| injectStatus.setPayloadOutput(injectUtils.getStatusPayloadFromInject(inject)); | ||
| injectStatusRepository.save(injectStatus); | ||
| InjectStatus injectStatusSaved = injectStatusRepository.save(injectStatus); | ||
| inject.setStatus(injectStatusSaved); |
There was a problem hiding this comment.
As you I don't like this approach of updating the object in the method as it can have non explicit impact. I know that is not an universal opinion but having both "return" + updating the inject seems more confusing to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.