Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the regression on executing external injects Issue/2220 #2305

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Jan 27, 2025

Proposed changes

  • updating the setInjectStatusAndExecuteInject method to set the status after calling initializeInjectStatus
  • moved the call to the initializeInjectStatus ouf of the "if needsExecutor" so the status is created for the external excutors that are pulling the status from the db

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug -> will be done after the refactoring

@heditar heditar added the filigran team use to identify PR from the Filigran team label Jan 27, 2025
@heditar heditar requested a review from RomuDeuxfois January 27, 2025 18:00
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 37.48%. Comparing base (1eaeb50) to head (b6d3b75).
Report is 4 commits behind head on release/current.

Files with missing lines Patch % Lines
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 0.00% 20 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2305      +/-   ##
=====================================================
+ Coverage              34.55%   37.48%   +2.92%     
- Complexity              1590     1763     +173     
=====================================================
  Files                    586      589       +3     
  Lines                  17991    19002    +1011     
  Branches                1169     1306     +137     
=====================================================
+ Hits                    6217     7123     +906     
- Misses                 11471    11538      +67     
- Partials                 303      341      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heditar heditar merged commit 3854057 into release/current Jan 28, 2025
6 checks passed
@heditar heditar deleted the issue/2220 branch January 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants