Economic calendar #2936
Merged
Economic calendar #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nw, we'll see how this evolves: alvarobartt/investpy#602 in the meantime... I'll add some try except in this PR to avoid breaking reports anyway #2878 |
|
Since there are likely to be merge conflicts I am going to wait for this to merge before continuing work on #2902. |
colin99d
force-pushed
the
economic_cal
branch
from
d26137c
to
8fe6df0
Compare
colin99d
approved these changes
Oct 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #2925 which replaces investpy as the source for economic events.
I have commented out the spread function as well since that relies on investpy as well (sorry @montezdesousa ).
Also fixes the pre commit that didier broke because he uses --no-verify. Public shaming you rn,