Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for offloading specific instances #134

Merged
merged 5 commits into from
Apr 27, 2024
Merged

Conversation

OpenBagTwo
Copy link
Owner

@OpenBagTwo OpenBagTwo commented Apr 27, 2024

Summary

Addresses #123

List of Changes

  • Pre-commit bump and auto-lint
  • $enderchest break [instance names...] will:
    1. check if the specified instances are registered to the chest (case sensitive)
    2. replace symlinks into the EnderChest folder from those instances with file copies
    3. deregister those instances from the chest

Tech Debt and Other Concerns

Not tech debt, but just wanted to note that this is the only action—besides test—that does not accept the Minecraft root as a positional argument (though the --root root flag still works), as it was too confusing trying to disambiguate the root from instance names. This is technically breaking backwards compatibility... but only for people who had previously fully uninstalled EnderChest.

Validation Performed

  • I have run this command to take an instance that was previously registered to EnderChest and verified that, post break, all the files were still in place, and the instance was still launchable / playable as before

PR Type

  • This PR introduces a breaking change (will
    require a bump in the minor version)
  • The changes in this PR are high urgency and necessitate a hotfix or patch
    release (will require rebasing off of release)
  • This is a release (staging) PR (maintainer use only)

Checklist:

  • I have read the contributor's guide
  • I have run mkdocs serve locally and ensured that all API docs and
    changes I have made to the static pages are rendering correctly, with all links
    working
  • All tech debt concerns have been resolved, documented as issues, or otherwise
    accepted
  • I agree to license my contribution to this project under
    the GNU Public License v3

@OpenBagTwo OpenBagTwo linked an issue Apr 27, 2024 that may be closed by this pull request
@OpenBagTwo
Copy link
Owner Author

This is the last piece of functionality for the v0.1.6, so once this PR is merged, it'll be time for a release candidate!

@OpenBagTwo OpenBagTwo merged commit 6c18461 into dev Apr 27, 2024
10 checks passed
@OpenBagTwo OpenBagTwo deleted the break-one branch April 27, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to offboard specific instances
1 participant