refactor/tweaked the docs

OpenBankProject · Jun 13, 2023 · 0cc0085 · 0cc0085
1 parent 855b50f
commit 0cc0085
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/obp-api/src/main/scala/code/api/util/ErrorMessages.scala b/obp-api/src/main/scala/code/api/util/ErrorMessages.scala
@@ -444,7 +444,7 @@ object ErrorMessages {
   val GetCustomerAccountLinksError = "OBP-30226: Could not get the customer account links."
   val UpdateCustomerAccountLinkError = "OBP-30227: Could not update the customer account link."
   val DeleteCustomerAccountLinkError = "OBP-30228: Could not delete the customer account link."
-  val GetConsentImplicitSCAError = "OBP-30229: Could not get the consent implicit SCA."
+  val GetConsentImplicitSCAError = "OBP-30229: Could not get the implicit SCA consent."
 
   val CreateSystemViewError = "OBP-30250: Could not create the system view"
   val DeleteSystemViewError = "OBP-30251: Could not delete the system view"
@@ -515,7 +515,7 @@ object ErrorMessages {
   val ConsumerKeyIsToLong = "OBP-35031: The Consumer Key max length <= 512"
   val ConsentHeaderValueInvalid = "OBP-35032: The Consent's Request Header value is not formatted as UUID or JWT."
   val RolesForbiddenInConsent = s"OBP-35033: Consents cannot contain the following Roles: ${canCreateEntitlementAtOneBank} and ${canCreateEntitlementAtAnyBank}."
-  val UserAuthContextUpdateRequestAllowedScaMethods = "OBP-35034: Only SMS and EMAIL are supported as SCA methods. "
+  val UserAuthContextUpdateRequestAllowedScaMethods = "OBP-35034: Unsupported as SCA method. "
 
   //Authorisations
   val AuthorisationNotFound = "OBP-36001: Authorisation not found. Please specify valid values for PAYMENT_ID and AUTHORISATION_ID. "

diff --git a/obp-api/src/main/scala/code/api/v3_1_0/APIMethods310.scala b/obp-api/src/main/scala/code/api/v3_1_0/APIMethods310.scala
@@ -3549,7 +3549,7 @@ trait APIMethods310 {
                   callContext
                 )
               } yield Future{status}
-            case v if v == StrongCustomerAuthentication.SMS.toString => // Not implemented
+            case v if v == StrongCustomerAuthentication.SMS.toString =>
               for {
                 failMsg <- Future {
                   s"$InvalidJsonFormat The Json body should be the $PostConsentPhoneJsonV310"
@@ -3566,7 +3566,7 @@ trait APIMethods310 {
                   callContext
                 )
               } yield Future{status}
-            case v if v == StrongCustomerAuthentication.IMPLICIT.toString => // Not implemented
+            case v if v == StrongCustomerAuthentication.IMPLICIT.toString =>
               for {
                 (consentImplicitSCA, callContext) <- NewStyle.function.getConsentImplicitSCA(user, callContext)
                 status <- consentImplicitSCA.scaMethod match {
@@ -3578,7 +3578,7 @@ trait APIMethods310 {
                       challengeText,
                       callContext
                     )
-                  case v if v == StrongCustomerAuthentication.SMS => // Not implemented
+                  case v if v == StrongCustomerAuthentication.SMS =>
                     Connector.connector.vend.sendCustomerNotification(
                       StrongCustomerAuthentication.SMS,
                       consentImplicitSCA.recipient,

diff --git a/obp-api/src/main/scala/code/api/v5_0_0/APIMethods500.scala b/obp-api/src/main/scala/code/api/v5_0_0/APIMethods500.scala
@@ -984,15 +984,15 @@ trait APIMethods500 {
             _ <- scaMethod match {
               case v if v == StrongCustomerAuthentication.EMAIL.toString => // Send the email
                 sendEmailNotification(callContext, consentRequestJson, challengeText)
-              case v if v == StrongCustomerAuthentication.SMS.toString => // Not implemented
+              case v if v == StrongCustomerAuthentication.SMS.toString =>
                 sendSmsNotification(callContext, consentRequestJson, challengeText)
               case v if v == StrongCustomerAuthentication.IMPLICIT.toString =>
                 for {
                   (consentImplicitSCA, callContext) <- NewStyle.function.getConsentImplicitSCA(user, callContext)
                   status <- consentImplicitSCA.scaMethod match {
                     case v if v == StrongCustomerAuthentication.EMAIL => // Send the email
                       sendEmailNotification(callContext, consentRequestJson.copy(email=Some(consentImplicitSCA.recipient)), challengeText)
-                    case v if v == StrongCustomerAuthentication.SMS => // Not implemented
+                    case v if v == StrongCustomerAuthentication.SMS =>
                       sendSmsNotification(callContext, consentRequestJson.copy(phone_number=Some(consentImplicitSCA.recipient)), challengeText)
                     case _ => Future {
                       "Success"