Adding @deprecated for accountIban in favour of BankAccountRouting

OpenBankProject · Sep 22, 2023 · 3b1a50a · 3b1a50a
1 parent 955a574
commit 3b1a50a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala b/obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala
@@ -2549,7 +2549,7 @@ trait APIMethods400 {
       "Create Account (POST)",
       """Create Account at bank specified by BANK_ID.
         |
-        |The User can create an Account for himself  - or -  the User that has the USER_ID specified in the POST body.
+        |The User can create an Account for themself  - or -  the User that has the USER_ID specified in the POST body.
         |
         |If the POST body USER_ID *is* specified, the logged in user must have the Role CanCreateAccount. Once created, the Account will be owned by the User specified by USER_ID.
         |

diff --git a/obp-api/src/main/scala/code/api/v5_0_0/APIMethods500.scala b/obp-api/src/main/scala/code/api/v5_0_0/APIMethods500.scala
@@ -301,7 +301,7 @@ trait APIMethods500 {
       "createAccount",
       "PUT",
       "/banks/BANK_ID/accounts/ACCOUNT_ID",
-      "Create Account",
+      "Create Account (PUT)",
       """Create Account at bank specified by BANK_ID with Id specified by ACCOUNT_ID.
         |
         |The User can create an Account for themself  - or -  the User that has the USER_ID specified in the POST body.

diff --git a/obp-api/src/main/scala/code/model/dataAccess/MappedBankAccount.scala b/obp-api/src/main/scala/code/model/dataAccess/MappedBankAccount.scala
@@ -14,6 +14,7 @@ class MappedBankAccount extends BankAccount with LongKeyedMapper[MappedBankAccou
 
   object bank extends UUIDString(this)
   object theAccountId extends AccountIdString(this)
+  @deprecated("Use BankAccountRouting model to store IBAN and other account routings", "22 Sept 2023" )
   object accountIban extends MappedString(this, 50)
   object accountCurrency extends MappedString(this, 10)
   object accountNumber extends MappedAccountNumber(this)
@@ -34,9 +35,13 @@ class MappedBankAccount extends BankAccount with LongKeyedMapper[MappedBankAccou
   //the last time this account was updated via hbci [when transaction data was refreshed from the bank.]
   //It means last transaction refresh date only used for HBCI now.
   object accountLastUpdate extends MappedDateTime(this)
-
+
+
+  @deprecated("Use BankAccountRouting model to store IBAN and other account routings", "22 Sept 2023" )
   object mAccountRoutingScheme extends MappedString(this, 32)
+  @deprecated("Use BankAccountRouting model to store IBAN and other account routings", "22 Sept 2023" )
   object mAccountRoutingAddress extends MappedString(this, 128)
+
   object mBranchId extends UUIDString(this)
 
   object accountRuleScheme1 extends MappedString(this, 10)