Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace allowableConversionType with conversionGroup #176

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

Agilulfo
Copy link
Contributor

@Agilulfo Agilulfo commented Oct 7, 2024

This is my attempt to fix #175

Instead of using allowableCoversionType that required to define for each scale the list of compatible scales I'm proposing to use a simpler group mechanism where a scale is part of a group of compatible scales.
A scale can be converted to any other scale of the same group.

I'm not entirely sure if this assumption is correct. please let me know if this is not the case

Copy link

github-actions bot commented Oct 7, 2024

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected <=999999 not covered statements, but got 609

St.
Category Percentage Covered / Total
🟢 Statements
87.5% (+0.02% 🔼)
609/696
🟡 Branches 67.54% 129/191
🟡 Functions 79.87% 119/149
🟢 Lines
86.69% (+0.02% 🔼)
560/646

Test suite run success

268 tests passing in 17 suites.

Report generated by 🧪jest coverage report action from 2ade068

src/scales/ewbank.ts Outdated Show resolved Hide resolved
src/GradeScale.ts Outdated Show resolved Hide resolved
@musoke
Copy link
Collaborator

musoke commented Oct 21, 2024

Thank you for this @Agilulfo ! This looks like a significant improvement 😀

Any idea what's going on with the failed coverage test? tests passed after rerunning.

@musoke
Copy link
Collaborator

musoke commented Oct 21, 2024

@Agilulfo, I'm happy to merge as is if you want to leave the finite set of options for later.

@Agilulfo
Copy link
Contributor Author

@musoke yeah let me try to figure out the enum

@musoke musoke merged commit 7badf00 into OpenBeta:develop Oct 28, 2024
4 checks passed
@musoke
Copy link
Collaborator

musoke commented Oct 28, 2024

Thank you @Agilulfo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "allowableConversionType" lists
2 participants