Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wo xml #29

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Build wo xml #29

wants to merge 29 commits into from

Conversation

zaibacu
Copy link
Contributor

@zaibacu zaibacu commented Sep 11, 2019

Ok, so in general these changes can be a bit controversial, but hear me out.

In general OpenCCG is designed in such way, that it relies on provided grammar XML to build all of the structures. In our case - XML generation was huge bottleneck and additional hassle.

What these changes does - they allow to fully construct Grammar, Lexicon, Rules and Types (if you know what you're doing, of course) at runtime without any need of parsing XML files.

@dmhowcroft
Copy link
Contributor

This sounds like an interesting idea to me; do you have a set of tests or documentation that demonstrate (1) that it doesn't break existing functionality and (2) how it helps in other use cases?

@zaibacu
Copy link
Contributor Author

zaibacu commented Sep 11, 2019

As far as not breaking standard functionallity, current tests should be sufficient to verify, will do that my self just to be sure

As for use cases, this is valuable when OpenCCG is being used as a library and rules are generated dynamically at runtime

@mwhite14850
Copy link
Member

mwhite14850 commented Sep 11, 2019 via email

@zaibacu
Copy link
Contributor Author

zaibacu commented Sep 12, 2019

Testing results:

[INFO] Results:
[INFO] 
[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0

Žygimantas Medelis added 5 commits September 27, 2019 08:56
commit 9a0cf2e
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:48:23 2019 +0300

    [maven-release-plugin] prepare for next development iteration

commit 0617aee
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:48:13 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.2

commit 5a00b63
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:47:52 2019 +0300

    release: setup pom to release to clojars

commit 3952bb4
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:44:03 2019 +0300

    release: setup pom to release to clojars

commit 368fb6b
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:40:14 2019 +0300

    release: setup pom to release to clojars

commit be4b36c
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:21:18 2019 +0300

    release: setup pom to release to clojars

commit d606ff0
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:09:57 2019 +0300

    [maven-release-plugin] prepare for next development iteration

commit 775c113
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:01:51 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.1

commit 4f598af
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 08:00:54 2019 +0300

    release: setup pom to release to clojars

commit f76d5c4
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 07:54:58 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.1

commit 8ff29d3
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 07:54:18 2019 +0300

    release: setup pom to release to clojars

commit 9b528cf
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:58:24 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.1

commit c780109
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:57:48 2019 +0300

    release: setup pom to release to clojars

commit 8e80523
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:53:16 2019 +0300

    [maven-release-plugin] prepare for next development iteration

commit 34d2faa
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:53:06 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.0

commit b8dd335
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:52:40 2019 +0300

    release: setup pom to release to clojars

commit f6ca8a6
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:51:04 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.0

commit b60de44
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:50:31 2019 +0300

    release: setup pom to release to clojars

commit 941af5c
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:47:58 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.0

commit e3614ad
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:47:38 2019 +0300

    release: setup pom to release to clojars

commit cd04e4f
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:40:53 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.0

commit 873534a
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:40:38 2019 +0300

    release: setup pom to release to clojars

commit 399daec
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:39:44 2019 +0300

    release: setup pom to release to clojars

commit 8c7d7f0
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:34:09 2019 +0300

    [maven-release-plugin] prepare release openccg-0.10.0

commit b355967
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:33:51 2019 +0300

    release: setup pom to release to clojars

commit c220cd5
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:32:38 2019 +0300

    release: setup pom to release to clojars

commit 1a107bd
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:31:59 2019 +0300

    [maven-release-plugin] prepare release openccg-1.0.0

commit d7501d3
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:31:42 2019 +0300

    release: setup pom to release to clojars

commit b53fd50
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:31:13 2019 +0300

    release: setup pom to release to clojars

commit b088ed6
Author: Žygimantas Medelis <[email protected]>
Date:   Fri Sep 27 06:27:14 2019 +0300

    release: setup pom to release to clojars

commit 66cace1
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:58:19 2019 +0300

    [maven-release-plugin] prepare release openccg-1.0.0

commit f730d15
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:57:50 2019 +0300

    release: setup pom to release to clojars

commit d11451a
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:56:42 2019 +0300

    release: setup pom to release to clojars

commit 202a929
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:53:31 2019 +0300

    [maven-release-plugin] prepare release openccg-1.0.0

commit ac3dce6
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:51:17 2019 +0300

    release: setup pom to release to clojars

commit f6097af
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:40:04 2019 +0300

    [maven-release-plugin] prepare release openccg-1.0.0

commit 16fad14
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:39:35 2019 +0300

    release: setup pom to release to clojars

commit 22229c1
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:37:50 2019 +0300

    [maven-release-plugin] prepare release ccg-1.0.0

commit 23f8c63
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:37:07 2019 +0300

    [maven-release-plugin] prepare release ccg-1.0.0

commit 7ce8249
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:36:51 2019 +0300

    release: setup pom to release to clojars

commit 33a71af
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:25:29 2019 +0300

    release: setup pom to release to clojars

commit 64bbfea
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:16:03 2019 +0300

    [maven-release-plugin] prepare release ccg-1.0.0

commit 743494f
Author: Žygimantas Medelis <[email protected]>
Date:   Thu Sep 26 17:14:46 2019 +0300

    release: setup pom to release to clojars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants