-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix off-by-one error in loop support #62
Conversation
LGTM. Thanks for the fix! I don't have plenty of looped audios to test. The test results above proves itself. |
Hmm CI seems failing. I'll try to fix that when not occupied. |
You may try Magia Record.
Hmm? Seems to be okay for me: https://ci.appveyor.com/project/segfault-bilibili/deretore/builds/42691233 |
I did nothing than authorizing AppVeyor as a GitHub app and then authorizing it to access my forked repo. Maybe you can just try to revoke access permissions for AppVeyor and then re-grant it in GitHub? |
However I saw an error in the build log (although it didn't seem to block building process), not sure whether this matters: https://ci.appveyor.com/project/segfault-bilibili/deretore/builds/42691233?fullLog=true#L234
|
There's another bug to be fixed: #63 |
I'm sorry but I think this change should be reverted. It didn't actually fix the problem correctly. I'll compose a new PR if I have time. |
Again I feel very sorry but I think my incorrect patch should be reverted. |
Not tested.Not heavily tested.Fix #61