-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update GoCloud to a version that supports s3ForcePathStyle
The upgrade to GoCloud v0.39.0 switched to AWS SDK v2 and dropped support for the `s3ForcePathStyle` query parameter in the GoCloud URL. Even though GoCloud v0.40.0 brought `use_path_style`, the legacy `s3ForcePathStyle` parameter no longer worked with that version. This would cause `gitaly` to fail with an `unknown query parameter`. google/go-cloud#3505 adds back `s3ForcePathStyle` as an alias for `use_path_style` to preserve backwards compatibility. This commit bumps the version to a pseudo-ref that supports `s3ForcePathStyle`. Diff: https://github.com/google/go-cloud/compare/v0.40.0..56954848c3 Relates to https://gitlab.com/gitlab-org/gitaly/-/issues/6489 Changelog: fixed
- Loading branch information
Showing
2 changed files
with
14 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters