-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize api error code handler #804
base: main
Are you sure you want to change the base?
Conversation
MR Evaluation:This feature is still under test, evaluation are given by AI and might be inaccurate. After evaluation, the code changes in the Merge Request get score: 86-90. Analysis for the evaluation score:
TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
About Us:Visit the OpenCSG StarShip website for the Dashboard and detailed information on CodeReview, CodeGen, and other StarShip modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
MR Summary:
The summary is added by @codegpt.
This Merge Request optimizes the API error code handler across various frontend components and utilities. Key updates include:
ElMessage.warning
for displaying error messages.useFetchApi
utility to handle unauthorized (401) errors uniformly by prompting a re-login dialog, and removing redundant error handling for 404 errors.usePermissionCheck
utility to correctly redirect unauthorized (403) access attempts to the unauthorized error page.