-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and remove current_user cookie #831
Conversation
MR Evaluation:This feature is still under test, evaluation are given by AI and might be inaccurate. After evaluation, the code changes in the Merge Request get score: 81-83. Analysis for the evaluation score:
TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
About Us:Visit the OpenCSG StarShip website for the Dashboard and detailed information on CodeReview, CodeGen, and other StarShip modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
|
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
MR Summary:
The summary is added by @codegpt.
This Merge Request focuses on refactoring the frontend to remove the reliance on the
current_user
cookie for user identification across various components, such as initialization guides, collection settings, endpoint details, and more. Instead, it introduces the use of aUserStore
to manage user state. This change enhances security and code maintainability by centralizing user state management. Additionally, it modifies the backend session handler to stop setting thecurrent_user
cookie, aligning with the frontend changes.Key updates:
vue3-cookies
usage withUserStore
for user state management in multiple frontend components.current_user
cookie setting in the backend session handler to enhance security.UserStore.username
to dynamically fetch user tokens when the username changes, improving the application's responsiveness to user state changes.