-
Notifications
You must be signed in to change notification settings - Fork 78
Feat : Add Collection Page #118 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : Add Collection Page #118 #194
Conversation
@Sabarish2317, may you tell me what the reference of this task, cause currently we have this tasks, for collection section, and 'Collection' page |
@Sabarish2317, got it, I saw your comment, now. This page is similar for 'All Products' and 'Garage Sale' pages, where we using as one component with props, may you check the implmentation and update your code, please. Also check the URL and test from which endpoint you fetching. |
@Alexandrbig1 I used api/collections/:collectionId to fetch the data and show the collections, users mostly navigate from the home page collection-section, rest of the implementations are working fine like add to card, click to view product details etc. |
@Sabarish2317, we don’t have an API route for |
@Alexandrbig1 Sorry for the confusion about /collections/:id . it already has lowercase & - hyphened id so I used it, Should I create a new function to accept "Pre Workout" -> "pre-workout" Could you accept this PR after checking for functionality and Raise an issue so after that I will refactor all similar pages such as all products, garage sale etc.. to use same shared component. I don't have much experience in open-source-repo contribution so you can guide me through :). |
@Sabarish2317, just make small updates to this PR, and I'll approve it, and then you can update it. But check fetch latest updates, check descriptio, and test api endpoints. |
@Alexandrbig1 ChangesFetched latest updates, resolved the conflicts (A duplicate collections-page page was in upstream)
New issue
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, and congrats on your PR being approved!
We’re excited to have your work as part of Open Code Chicago’s Hacktoberfest 2025 project.
@Alexandrbig1 Sorry got mail that there is a build error due to lint issue (unused declaration) should I resolve that and commit. |
@Sabarish2317, thanks for the contribution! A few small, important fixes to improve safety and robustness before merging:
Great work. |
Pull Request
Create the Collection Page, similar to the existing All Products and Garage Sale pages, but using a dynamic URL and API endpoint to display products by collection name. #118
Description
Kept the sorting, filtering logic similar to product page and add other functionalities untouched, reused the same product card. The :name is dynamic in the endpoint and user can navigate from the collection section of the home page.
Issue : Create a common filtering & sorting logic to use across all product listing page
Screenshots
Checklist