Improved memory handling in oc_dialog::SortUUIDList #1126
+21
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved memory handling and early release of allocated resources short improve situatin for Issue OpenCollarTeam#1119.
NikkiLacrima
changed the title
|
This patch also allow the full number of 32 sensor results to be used in the sensor handling, not in the current patch but its a simple change. Also tested in places where force sit returns 32 results. |
Pingout
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Tested for functionality, everything appears to work as expected. The Force Sit function now returns 32 items without error, and the detach app will also return 32 worn items without crashing.
I believe that @Medea-Destiny would like to review this scrpt for workflow. I will approve this and tag it with Don't Merge Yet awaiting Medea's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved memory handling and early release of allocated resources should improve situation for Issue #1119. Simple drop in replacement for oc_dialog.
This version has been tested for two months and no regressions seen.
As long as only a single owner is accessing the Detach app menus at a time problem should be fixed.