Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IDP keystore management #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

veselov
Copy link

@veselov veselov commented Feb 3, 2021

Fixes #65

  • IdpConfiguration needs to provide keyStore password to shared configuration, or else wrong password will be used if configured
  • Adding new entities didn't create keystores for them
  • Changed default password to trip test failure
  • Provide JKS key manager with bottomless password map

Now, that last bit got me the most cringing. Whoever wrote SAML JKSKeyManager should be fully ashamed of themselves for not making it flexible enough to source passwords from some other place but just a map of passwords. The only other way to fix this (given the implementation), is to recreate the JKS key manager every time there is a new entity, but then we'll need to keep the password map locally. Let me know if you'd like me to change that bit.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.16%. Comparing base (cf473a0) to head (820af6a).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/mujina/idp/WebSecurityConfigurer.java 30.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #66      +/-   ##
============================================
- Coverage     91.28%   89.16%   -2.13%     
- Complexity      155      156       +1     
============================================
  Files            29       29              
  Lines           551      572      +21     
  Branches         11       11              
============================================
+ Hits            503      510       +7     
- Misses           37       51      +14     
  Partials         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems changing entity ID
1 participant