Implement CI #12
Open
Implement CI #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… easier to analyze the code In raft_log_replication.py: start to write test that log replication happens correctly if leadership changes In raft_node.py: add a couple of lines of code to close node after each test, so that after running pytest it does not crash new issue: after the leader changes, the new leader is not aware of the latest index of the neighboring nodes and begins to rewrite them, even though his nodes completely coincide with the neighboring node.
Add line "echo "PYTHONPATH=$PWD/cyraft" >> $GITHUB_ENV"
Add lines: 1. "echo "PYTHONPATH=$PYTHONPATH:$HOME/cyraft/demo/custom_data_types:$HOME/cyraft/demo/public_regulated_data_types" >> $GITHUB_ENV" 2. "- name: Verify PYTHONPATH run: echo $PYTHONPATH - name: List directory for debugging run: ls -R"
… easier to analyze the code In raft_log_replication.py: start to write test that log replication happens correctly if leadership changes In raft_node.py: add a couple of lines of code to close node after each test, so that after running pytest it does not crash new issue: after the leader changes, the new leader is not aware of the latest index of the neighboring nodes and begins to rewrite them, even though his nodes completely coincide with the neighboring node.
|
It's best to finish solving the remaining issues with the previous MR before continueing with the new one. :) |
…Garage#18) * Changed the logic of the terms, and also changed the tests * Update tests/raft_node.py Co-authored-by: maksimdrachov <[email protected]> * Made some minor changes --------- Co-authored-by: maksimdrachov <[email protected]>
) * Changed the logic of the terms, and also changed the tests * Update tests/raft_node.py Co-authored-by: maksimdrachov <[email protected]> * Made some minor changes * In node.py: expanded the log information for some values to make it easier to analyze the code In raft_log_replication.py: start to write test that log replication happens correctly if leadership changes In raft_node.py: add a couple of lines of code to close node after each test, so that after running pytest it does not crash new issue: after the leader changes, the new leader is not aware of the latest index of the neighboring nodes and begins to rewrite them, even though his nodes completely coincide with the neighboring node. * Added test _unittest_raft_leader_changes for log_replication.py * In node.py: expanded the log information for some values to make it easier to analyze the code In raft_log_replication.py: start to write test that log replication happens correctly if leadership changes In raft_node.py: add a couple of lines of code to close node after each test, so that after running pytest it does not crash new issue: after the leader changes, the new leader is not aware of the latest index of the neighboring nodes and begins to rewrite them, even though his nodes completely coincide with the neighboring node. * Added test _unittest_raft_leader_changes for log_replication.py * Adapted the test to term Changes * Returned the deleted fragment from the test _unittest_raft_log_replication() * Reformatted code * Returned the test _unittest_raft_node_heartbeat() * Added Black Formatter to the VSCode * Formatted tests * Changed raft_node.py tests --------- Co-authored-by: maksimdrachov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.