Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#895] Better oneOf validation messages for records #1235

Merged
merged 8 commits into from
Oct 22, 2019
Merged

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented Oct 2, 2019

#895

(Still needs updating to a lib-cove release once OpenDataServices/lib-cove#31 is merged/released.)

@Bjwebb
Copy link
Member Author

Bjwebb commented Oct 2, 2019

@Bjwebb
Copy link
Member Author

Bjwebb commented Oct 11, 2019

Translation done. @odscjames This should be ready for final review now.

#: cove_360/templates/cove_360/explore.html:54
#: cove_360/templates/cove_360/explore.html:107
msgid "The file was "
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this come from with no Translation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is only in 360 CoVE, which we don't translate.

@Bjwebb Bjwebb merged commit 13c77e1 into master Oct 22, 2019
@Bjwebb Bjwebb deleted the 895-oneOf-messages branch October 22, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants