Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json_input: If json_dict is not a dict, return a useful error/warning #448

Merged
merged 2 commits into from
Jul 4, 2024
Merged

json_input: If json_dict is not a dict, return a useful error/warning #448

merged 2 commits into from
Jul 4, 2024

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented Jun 30, 2024 •
edited
Loading

@Bjwebb Bjwebb force-pushed the json-dict-not-dict-warning branch from f47b639 to e2d68c9 Compare June 30, 2024 15:43
@Bjwebb
Copy link
Member Author

Bjwebb commented Jun 30, 2024

@jpmckinney Does this look like what you were expecting?

@jpmckinney
Copy link
Contributor

Yes, looks good!

@Bjwebb Bjwebb requested a review from R2ZER0 July 4, 2024 11:58
@Bjwebb Bjwebb force-pushed the json-dict-not-dict-warning branch from e2d68c9 to 72fe6ab Compare July 4, 2024 16:54
R2ZER0
R2ZER0 approved these changes Jul 4, 2024
View reviewed changes
Copy link

@R2ZER0 R2ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Bjwebb Bjwebb merged commit 1d1c662 into main Jul 4, 2024
28 checks passed
@Bjwebb
Copy link
Member Author

Bjwebb commented Jul 4, 2024 •
edited
Loading

I will make a release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R2ZER0 R2ZER0 R2ZER0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bjwebb @jpmckinney @R2ZER0