Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some typos #459

Closed
wants to merge 3 commits into from
Closed

Some typos #459

wants to merge 3 commits into from

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Aug 30, 2024

and a few minor code details in the 3rd commit

@odscjames
Copy link
Contributor

Thank you! Can I ask how you decided we don't need to catch IOError - was there some tool that was used to detect this?

@jpmckinney
Copy link
Contributor

@odscjames
Copy link
Contributor

Ah, thank you! I will sort this PR for merging after another one has gone in.

@fchapoton
Copy link
Contributor Author

I am using the tool ruff, which can check many things.

Here : https://docs.astral.sh/ruff/rules/os-error-alias/

odscjames pushed a commit that referenced this pull request Sep 13, 2024
odscjames pushed a commit that referenced this pull request Sep 13, 2024
@odscjames odscjames closed this in c7de0e7 Sep 17, 2024
@odscjames
Copy link
Contributor

Thank you! Merged in.

@fchapoton fchapoton deleted the some_typos branch September 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants