Skip to content

Commit

Permalink
Merge pull request #77 from OpenDataServices/variable-name-typo
Browse files Browse the repository at this point in the history
lib.common: Fix typo of var name, so messages are grouped correctly.
  • Loading branch information
Bjwebb authored Apr 8, 2021
2 parents b0a573c + 2d273f0 commit a7be375
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 2 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ jobs:
pip install -e ./lib-cove-${{ matrix.cove }}/
pip list
- name: Compile Messages
if: matrix.cove == 'ocds'
run: |
cd cove-${{ matrix.cove }}
python manage.py compilemessages
# Ensure that compilemessages gets run for lib-cove-web
pushd /opt/hostedtoolcache; pwd; django-admin compilemessages; popd
- name: Test cove instance
run: |
cd cove-${{ matrix.cove }}
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [0.22.1] - 2021-04-08

### Fixed

- Fix a typo of a variable name, that meant `date-time` and `uri` validation messages were incorrectly grouped

## [0.22.0] - 2021-02-25

### Changed
Expand Down
2 changes: 1 addition & 1 deletion libcove/lib/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ def get_schema_validation_errors(
]:
instance = e.instance

if e.validator == "format" and e.validator not in ["date-time", "uri"]:
if e.validator == "format" and validator_type not in ["date-time", "uri"]:
instance = e.instance

if getattr(e, "error_id", None) in ["oneOf_any", "oneOf_each"]:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

setup(
name="libcove",
version="0.22.0",
version="0.22.1",
author="Open Data Services",
author_email="[email protected]",
url="https://github.com/OpenDataServices/lib-cove",
Expand Down

0 comments on commit a7be375

Please sign in to comment.