Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.32.1 #146

Merged
merged 3 commits into from
Jul 8, 2024
Merged

release: 0.32.1 #146

merged 3 commits into from
Jul 8, 2024

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented Jun 28, 2024

No description provided.

Currently tests fail, because the pinned lib-cove-web has a bug. It's
generally useful to use the latest lib-cove-web, as we tend to upgrade
this library and that at the same time.
@Bjwebb Bjwebb requested a review from R2ZER0 June 28, 2024 15:00

- name: Install
run: |
pip install -r requirements_dev.txt
# Temporary fix so we don't try to install libcove from a non-existent
# branch
sed -i '/=libcove/d' cove-${{ matrix.cove}}/requirements_dev.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because cove-ocds pulls in a fork of this repo that no longer exists. We install it as part of our integration tests, but can delete the line from requirements.txt as we explicitly install this version of the library.

Copy link

@R2ZER0 R2ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Though what is this "temporary fix" re requirements?

@Bjwebb Bjwebb merged commit 19ae2ec into main Jul 8, 2024
22 checks passed
@Bjwebb Bjwebb deleted the release-0.32.1 branch July 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants