fix: Use correct modbus addresses for Janitza UMG96RM(E) meter #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation used 8xx addresses which are programmable. Switched to 190xx addresses, which cannot change. See https://www.janitza.com/files/download/manuals/current/UMG96RM/E/janitza-mal-umg96rme-en.pdf page 19.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #2930 +/- ##
=============================================
+ Coverage 56.62% 56.62% +0.01%
- Complexity 9500 9501 +1
=============================================
Files 2251 2251
Lines 96049 96049
Branches 7090 7090
=============================================
+ Hits 54374 54378 +4
+ Misses 39675 39672 -3
+ Partials 2000 1999 -1 |
|
@pooran-c: Could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation used 8xx addresses which are programmable. Switched to 190xx addresses, which cannot change. See https://www.janitza.com/files/download/manuals/current/UMG96RM/E/janitza-mal-umg96rme-en.pdf page 19.
I've tested this change with two different setups
Setup 1: Meter was programmed in the 8xx address range and working before this change with OpenEMS. After this change it still worked.
Setup 2: Meter was not programmed in the 8xx address range and not working before this change with OpenEMS. After this change it worked.