Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B6 Test #1075

Merged
merged 1 commit into from
Nov 15, 2023
Merged

B6 Test #1075

merged 1 commit into from
Nov 15, 2023

Conversation

yadhiramorales
Copy link
Contributor

Created B6 test according to testing.md from DesignDocs

Fixes one of the tests in #962

(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)

Testing readings

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

Limitations

(Describe any issues that remain or work that should still be done.)

@yadhiramorales
Copy link
Contributor Author

@huss Hi there, I believe this code effectively creates the B6 test from issue #962. It passes when testing the file directly (npm run testsome src/server/test/web/readingsBarMeterQuantity.js).

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @yadhiramorales for their first contribution to OED. A code review found no issues and testing found it worked as expected. Congratulations on your first approved pull request.

@huss huss merged commit c7cc519 into OpenEnergyDashboard:development Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants