-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update packages for npm warnings #1251
Conversation
This gets OED to a fairly recent version of superagent but still warned to upgrade. It also resolves the warning for formidable.
I'm seeing the following warning.
This PR has sat for a while, and I'm wondering if this is something that was missed or may be new that should be looked into. |
Thanks for asking. I went back to my notes (glad I kept them while I worked on this :-) and found this: [email protected] is 5 years old. [email protected] is latest stable from 1 year ago so try installing that. This got us to [email protected] but still warning for deprecated for v9.0.0+ but will have to live with this. May also want to upgrade chai. It also update the @types and changed other packages. It passed all tests so seems okay. So, when I did this there was not a version of the package that had this as a dependency that could get us to superagent@9. For now, I think we can let it go and hope that the next package sweep/update will enable this. |
I saw this now had a merge conflict so I fixed it up. I hope I did not leave any unneeded packages. I noticed that this created a new unneeded package on @types/history so I fixed that too. This is a new change. |
The recent PR #1294 does upgrade superagent but is having issues that need to resolve. |
Description
This updates packages to address some of the warnings during an OED install from the npm install. It helped with:
A number of other packages were modified as part of this process. Testing has not found any issue.
Type of change
Checklist
Limitations
It does not fix these:
This does not do a general package update.