Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages for npm warnings #1251

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

huss
Copy link
Member

@huss huss commented Jun 2, 2024

Description

This updates packages to address some of the warnings during an OED install from the npm install. It helped with:

  • Update chai-http that allowed update of superagent. This gets OED to v8 which is not too old verses the most recent v9. npm still warns about v8 being deprecated. This also fixes the warning about formidable that came from superagent by getting to v2.
  • Update multer to latest lts. This fixes the warnings.

A number of other packages were modified as part of this process. Testing has not found any issue.

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

It does not fix these:

This does not do a general package update.

huss added 2 commits June 2, 2024 16:11
This gets OED to a fairly recent version of superagent but still warned
to upgrade. It also resolves the warning for formidable.
@ChrisMart21
Copy link
Contributor

I'm seeing the following warning.

WARN deprecated [email protected]: Please upgrade to v9.0.0+ as we have fixed ....

This PR has sat for a while, and I'm wondering if this is something that was missed or may be new that should be looked into.

@huss
Copy link
Member Author

huss commented Jul 7, 2024

I'm seeing the following warning.

WARN deprecated [email protected]: Please upgrade to v9.0.0+ as we have fixed ....

This PR has sat for a while, and I'm wondering if this is something that was missed or may be new that should be looked into.

Thanks for asking. I went back to my notes (glad I kept them while I worked on this :-) and found this:

[email protected] is 5 years old. [email protected] is latest stable from 1 year ago so try installing that. This got us to [email protected] but still warning for deprecated for v9.0.0+ but will have to live with this. May also want to upgrade chai. It also update the @types and changed other packages. It passed all tests so seems okay.

So, when I did this there was not a version of the package that had this as a dependency that could get us to superagent@9. For now, I think we can let it go and hope that the next package sweep/update will enable this.

@huss
Copy link
Member Author

huss commented Jul 7, 2024

I saw this now had a merge conflict so I fixed it up. I hope I did not leave any unneeded packages.

I noticed that this created a new unneeded package on @types/history so I fixed that too. This is a new change.

@huss
Copy link
Member Author

huss commented Jul 9, 2024

I'm seeing the following warning.

WARN deprecated [email protected]: Please upgrade to v9.0.0+ as we have fixed ....

This PR has sat for a while, and I'm wondering if this is something that was missed or may be new that should be looked into.

Thanks for asking. I went back to my notes (glad I kept them while I worked on this :-) and found this:

[email protected] is 5 years old. [email protected] is latest stable from 1 year ago so try installing that. This got us to [email protected] but still warning for deprecated for v9.0.0+ but will have to live with this. May also want to upgrade chai. It also update the @types and changed other packages. It passed all tests so seems okay.

So, when I did this there was not a version of the package that had this as a dependency that could get us to superagent@9. For now, I think we can let it go and hope that the next package sweep/update will enable this.

The recent PR #1294 does upgrade superagent but is having issues that need to resolve.

@huss huss merged commit 34080bc into OpenEnergyDashboard:development Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants