Added test BG14 #1352
Added test BG14 #1352
Conversation
There was a problem hiding this comment.
Thanks to @Emily-D-2003 for their first pull request. First, my records do not indicate you signed the CLA. OED cannot accept your contribution without that. Second, I have made several comments to consider. I believe this is why the GitHub test failed for the new test case (it also failed locally on my machine).
|
@Emily-D-2003 Do you need any help with this pull request? I was checking the status of the pull requests and wondered about this one. |
Thank you for the detailed comments and for checking in about the status of this PR! Just committed the updates made according to your comments. One question - when attempting to sign the CLA, the webpage linked in the README returned a HTTP 404. Wondering if you're seeing the same? Thanks! |
Someone else just reported this and has a PR in to fix it in one place and I'll do the others. The correct link is https://openenergydashboard.org/developer/cla/. Thanks for asking. |
|
There is some issue that I have not yet figured out. I plan to work more on this later. FYI for @Emily-D-2003 . |
There was a problem hiding this comment.
Thanks to @Emily-D-2003 for their changes. They addressed the comments already made but another item has now appeared. Please see my comment for details and options to address this. Note that testing the code locally (directions on the design docs test page) may help with working on this if you do that. Once that is addressed and the CLA is done then this should be fine.
| ]; | ||
|
|
||
| //loads data into database | ||
| await prepareTest(unitDatakWh, conversionDatakWh, meterDatakWhGroups, groupDatakWh); |
There was a problem hiding this comment.
The issue is that the provided meters and groups have a default graphic unit of kWh but this test does not create that unit. This causes the code to fail. What needs to happen is the needed meters and groups must be created within this test. It is similar to the standard ones but modified somewhat. I created the needed code to test the solution. If you want that code or for me to commit/push the solution then let me know.
|
@Emily-D-2003 It has been over a month since the last comments where made on this PR and no changes have been made. I plan to close this PR in one week (about 12/8) if the updates are not made or no comment is made to indicate this is active. |
@huss Apologies for the delay! These comments slipped through somehow. On it, aiming to push the updates in a week. Thanks! |
Description
Added tests BG14 from design document.
Partly addresses #962
Type of change
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)