Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log message web page #1390

Merged
merged 25 commits into from
Dec 10, 2024
Merged

Log message web page #1390

merged 25 commits into from
Dec 10, 2024

Conversation

nmqng
Copy link
Contributor

@nmqng nmqng commented Nov 20, 2024 •
edited
Loading

Description

Continue ianLewis8's work on Draft Pull Request #1327.
The purpose of this pull request is to create the web page that allows admin to look at the log file on a web page.

Fixes #712

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

ianLewis8 and others added 20 commits July 30, 2024 15:18
@ianLewis8
Developing new database model
5e2b5bd 
Initial commit towards making a database to store logs.
@ianLewis8
LogMsg Model
b4dae28 
Almost finished LogMsg database model
@ianLewis8
slight changes
195396c 
forgot to include these in push
@ianLewis8
Merge branch 'OpenEnergyDashboard:development' into development
60fda20
@ianLewis8
Update get logs from dates
0758401 
added header file
@nmqng
create logmsg table in database
d0a4fc5
@nmqng
upload for fetching logs data from server question
c72148b
@nmqng
Pre-review version for log message table now able to call log data fr…
acc3e1a 
…om server
@nmqng
fix writing the whole log file to database again to only write new log
02bc0d9
@nmqng
improve UI by using pagination
b18deaa
@nmqng
update UI to show only first 80 characters for long log messages
f1f951e
@nmqng
add select all log type option and apply translate function for all t…
fcbd0a8 
…exts
@nmqng
update UI for log msg page including pagination, show all button, new…
38b5bbb 
… refresh button, new picking log msg UI
@nmqng
bring back log type filter for table and update log type downdrop for…
5a15a02 
… fetching data
@nmqng
update so that instead of making 4 requests for 4 types, logTypes is …
9929eda 
…now being sent as array for fetching, add logLimit for fetching, validation
@nmqng
fix some comments from origin draft pull request
43b51fb
@nmqng
add comments for LogMsgComponent
a47e0bf
@nmqng
update using time interval instead of date for log date range
2819142
@nmqng
update 'Select All' button action
5c3865e
@nmqng
Merge branch 'development' into pr/ianLewis8/1327
d887604
@nmqng nmqng changed the title Pr/ian lewis8/1327 Log message web page Nov 20, 2024
huss
huss requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @nmqng for addressing another issue. Overall, this works well and the UI is very nice. I've made some comment to consider. Also, there is now a merge conflict so let me know if you want me to deal with it (or you can). Let me know if anything is not clear.

src/client/app/components/RouteComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/translations/data.ts Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
@nmqng
Copy link
Contributor Author

nmqng commented Nov 27, 2024 •
edited
Loading

Thanks to @nmqng for addressing another issue. Overall, this works well and the UI is very nice. I've made some comment to consider. Also, there is now a merge conflict so let me know if you want me to deal with it (or you can). Let me know if anything is not clear.

Hi Steve, I think I can try to fix the merge conflict myself and I'll let you know if I need any help. I will have a look at your comments for this issue after I finish the compareLine one, which is about half completed.

@huss huss mentioned this pull request Dec 1, 2024
Closed
5 tasks
huss
huss requested changes Dec 7, 2024
View reviewed changes
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @nmqng for all the updates. This is looking good. I made a few comments to consider.

src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Outdated Show resolved Hide resolved
src/server/routes/logs.js Outdated Show resolved Hide resolved
src/server/routes/logs.js Show resolved Hide resolved
src/server/services/addLogMsg.js Show resolved Hide resolved
src/server/services/addLogMsg.js Outdated Show resolved Hide resolved
src/client/app/components/admin/LogMsgComponent.tsx Show resolved Hide resolved
src/server/models/LogMsg.js Show resolved Hide resolved
@nmqng nmqng requested a review from huss December 9, 2024 21:33
huss
huss approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @nmqng for addressing all the comments. Review and testing found it works as desired. Congratulations on your first accepted contribution to OED.

@huss huss merged commit b65b7b5 into OpenEnergyDashboard:development Dec 10, 2024
3 checks passed
@nmqng nmqng mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huss huss huss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dealing with log files
3 participants
@nmqng @huss @ianLewis8