Added warnings to admin preferences component

[hinyan17]

Description

Added input validation and warnings for fields on the admin preferences form. Everything that wasn't multiple choice or drop down menu was checked. These fields are: meter reading frequency, min and max reading value, min and max date, reading gap, number of errors, warning file size, and file size limit.

Fixes the TODO associated with PreferencesComponent. (36 on the TODO list)

Type of change

• Note merging this changes the database configuration.
• This change requires a documentation update

Checklist

• I have followed the OED pull request ideas
• I have removed text in ( ) from the issue request
• You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

none

[huss]

Thanks to @hinyan17 for doing this improvement. Review and testing found it works fine. I've made a couple of comment to consider.

[huss]

Thanks to @hinyan17 for addressing the comment. I'm sorry this sat so long - somehow I missed the update. I've made a couple of comments to consider.

[hinyan17]

While I was going through CreateMeterModalComponent I noticed that all of the invalid functions are called anonymously and inline. Also, the final check if the whole form is valid is done with a redux selector, isValidCreateMeter. Should I implement something similar for PreferencesComponent? It looks a lot cleaner than my current solution and is probably better for consistency.

[huss]

While I was going through CreateMeterModalComponent I noticed that all of the invalid functions are called anonymously and inline. Also, the final check if the whole form is valid is done with a redux selector, isValidCreateMeter. Should I implement something similar for PreferencesComponent? It looks a lot cleaner than my current solution and is probably better for consistency.

That seems fine if you want to do it.

[huss]

Thanks to @hinyan17 for the quick update. I responded to your two questions and made one small comment.

[huss]

Everything now looks good. Thanks to @hinyan17 for another accepted contribution to OED.