Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed C8 Test Case #1394

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Conversation

AlexanderORuban
Copy link
Contributor

@AlexanderORuban AlexanderORuban commented Nov 26, 2024

Description

Added C8 test case in src/server/test/web/readingsCompareMeterQuantity.js

Alexander Ruban - @AlexanderORuban
Tavparsad Singh - @TavSingh
Madeleine Chance - @mechance782
Diana Khachaturova - @qopci

Fixes Test Case C8 for issue #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @AlexanderORuban, @TavSingh, @mechance782 & @qopci for their first pull request. Review and testing found it works as desired. I have made one comment to suggest a modification on how items are defined. Please let me know if you have any questions.

src/server/test/web/readingsCompareMeterQuantity.js Outdated Show resolved Hide resolved
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update. It resolves the one comment. Testing and review found everything is ready. Congratulations to @AlexanderORuban, @TavSingh, @mechance782 & @qopci on your first accepted contribution.

@huss huss merged commit 82a74d6 into OpenEnergyDashboard:development Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants