Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case CG3 #1405

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

Unknown31414652
Copy link
Contributor

@Unknown31414652 Unknown31414652 commented Dec 6, 2024

Description

Added test CG3 from design docs testing.md
Partly addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

##Note
I am part of CodeDay doing this as a micro-internship with Shubham Waldiya

@huss
Copy link
Member

huss commented Dec 6, 2024

@Unknown31414652 Did you do this work alone or with a team? If a team, could you let me know the team members to verify the CLA is signed by all of them. Thanks.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @Unknown31414652 for this pull request. Review and testing found it works as desired. It can be merged once my CLA comment is addressed.

@Unknown31414652
Copy link
Contributor Author

My group member Shubham Waldiya signed the CLA

@huss
Copy link
Member

huss commented Dec 8, 2024

Congratulations to @Unknown31414652 & @HiThere-12345 on your first accepted contribution to OED.

@huss huss merged commit 6bd9c6b into OpenEnergyDashboard:development Dec 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants