Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #590 Automatic Site Backup #1408

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

vladoleksiyenko
Copy link
Contributor

Description

Fixed the script that was previously mentioned in the closed PR 759. This along with the cron job template that will be mentioned in the #590 issue will allow automatic backup of the website.

Fixes #590

Collaborators

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the [OED pull request]
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the [OED Contributing License Agreement] and each author is listed in the Description section.

Limitations

The cron template will be mentioned in the comments, that documentation will be need to be added to the webpage.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @MattMiss, @vladoleksiyenko, @brandonviorato & @Gene7Him for addressing this issue. Testing found it mostly works as expected. I make a few comment to consider. Also, OED is likely to create a cron job template to allow sites to automatically run this script at desired intervals. Let me know if you want to be involved in that and I can give more details. (removed since I realized you had put a file on the issue)

src/scripts/backupScript.sh Outdated Show resolved Hide resolved
src/scripts/backupScript.sh Outdated Show resolved Hide resolved
src/scripts/backupScript.sh Show resolved Hide resolved
vladoleksiyenko and others added 2 commits December 10, 2024 17:10
… errors, indicated that OED docker database container must be running
I forgot to mention this in my previous comments so I added a final output
statement to tell where the backup was placed.
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments. Review and testing found it works as desired. Congratulations to @MattMiss, @vladoleksiyenko, @brandonviorato & @Gene7Him on have this contribution accepted by OED.

@huss huss merged commit 51d4d23 into OpenEnergyDashboard:development Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatic site backup
2 participants