Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1187 - Horizontal shift when show error bars #1409

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Issue 1187 - Horizontal shift when show error bars #1409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/client/app/components/LineChartComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,13 @@ export default function LineChartComponent() {
return <SpinnerComponent loading height={50} width={50} />;
}


// Check if there is at least one valid graph
const enoughData = data.find(data => data.x!.length > 1);
// Customize the layout of the plot
// See https://community.plotly.com/t/replacing-an-empty-graph-with-a-message/31497 for showing text not plot.
if (data.length === 0) {
return <h1>{`${translate('select.meter.group')}`} </h1>;
} else if (!enoughData) {
}
// Checks if there is enough data for at least one valid graph
else if (!data[0].x) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have stopped the message about no data in range for the meter. I found this by changing the range outside all points.

return <h1>{`${translate('no.data.in.range')}`}</h1>;
} else {
return (
Expand All @@ -93,7 +92,8 @@ export default function LineChartComponent() {
legend: { x: 0, y: 1.1, orientation: 'h' },
// 'fixedrange' on the yAxis means that dragging is only allowed on the xAxis which we utilize for selecting dateRanges
yaxis: { title: unitLabel, gridcolor: '#ddd', fixedrange: true },
xaxis: { rangeslider: { visible: true }, showgrid: true, gridcolor: '#ddd' }
//Range must be between these values to allow error bars to show properly
xaxis: { rangeslider: { visible: true }, showgrid: true, gridcolor: '#ddd', range: [data[0].x[0], data[0].x[data[0].x.length - 1]]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an issue where the slider is wrong if there were multiple lines that span different ranges. I think this probably needs to be the min of all first points and the max of all end points to be sure it spans the entire range of all lines.

}}
config={{
responsive: true,
Expand Down