Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #962, Test Case CG5 #1411

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

mRosenthal937
Copy link
Contributor

Description

Wrote code for test case CG5 in the file readingsCompareGroupQuantity.js, allowing test case CG5 to successfully run.

Done as part of participating in a CTI program to allow developers to get some beginner-friendly open-source experience.

Worked with Kevin Beltran and Bo Liu as part of CTI.

@mRosenthal937
@bo2020bo
@KevinBeltran23

Partly addresses issue #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the [OED Contributing License Agreement] and each author is listed in the Description section.

Limitations

No additional issues as known.

@huss
Copy link
Member

huss commented Dec 17, 2024

Thanks to @mRosenthal937, @bo2020bo & @KevinBeltran23 for this contribution to OED. The OED records do not indicate that any of you have signed the CLA. If this is correct, please use this link to do this so the pull request can be reviewed. If you think this is incorrect then please let me know.

@KevinBeltran23
Copy link

Thank you @huss for notifying us.
I believe everyone on our team has filled out the CLA by now.
Please let us know if anything is still missing.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @mRosenthal937, @bo2020bo & @KevinBeltran23 for their first contribution to OED. I'm sorry it took me this long to review as I was tied up. Review and testing found it works as expected. Congratulation on your first accepted contribution to OED.

@huss huss merged commit 65f5b3f into OpenEnergyDashboard:development Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants