Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readingsCompareMeterQuantity.js #1413

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/scripts/backupScript.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
#!/bin/bash
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

# The OED Docker database container must be running for this script to work

# Input the pathname for the desired backup directory
# ie PATH="/home/<your_username>/path_to/database_dumps/"
# This path MUST exist, otherwise, this script will attempt to create the directory, or fail.

# This could probably be programmatically populated. Currently needs to be set manually
db_dump_path="/home/<username>/database_dumps" #INPUT REQUIRED

# Checks to see if the directory is exists
# If not, it will display a message, and attempt to create the backup directory
if [ ! -d "$db_dump_path" ]; then
echo "Backup directory does not exist. Creating it now..."
mkdir -p "$db_dump_path" || { echo "Failed to create directory. Exiting."; exit 1; }
fi

# Generate a timestamp to append to the dump file.
date=`date +%Y-%m-%d_%H_%M_%S`

# Set the final path for the backup file
final_path="${db_dump_path}/dump_${date}.sql"

# Perform the backup using pg_dump
docker compose exec database pg_dump -U oed > "$final_path"

echo "OED database backup placed in ${final_path}"
14 changes: 13 additions & 1 deletion src/server/test/web/readingsCompareMeterQuantity.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,19 @@ mocha.describe('readings API', () => {
expectCompareToEqualExpected(res, expected);
});

// Add C6 here
mocha.it('C6: 28 day shift end 2022-10-31 17:12:34 (partial hour) for 15 minute reading intervals and quantity units & kWh as kWh', async () => {
await prepareTest(unitDatakWh, conversionDatakWh, meterDatakWh);
const unitId = await getUnitId('kWh');
const expected = [108269.924822581, 108889.847659507];
const res = await chai.request(app).get(`/api/compareReadings/meters/${METER_ID}`)
.query({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes need to be backquotes so the METER_ID is treated as a variable, e.g., `/api/compareReadings/meters/${METER_ID}`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thank you for your prompt feedback!

curr_start: '2022-10-09 00:00:00',
curr_end: '2022-10-31 17:12:34',
shift: 'P28D',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specified time was '2022-10-31 17:12:34'.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thank you for your prompt feedback!

graphicUnitId: unitId
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "d" in graphicUnitID must be lowercase.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! We'll get to work making those changes and testing on our local machine.

expectCompareToEqualExpected(res, expected);
});

mocha.it('C8: 1 day shift end 2022-10-31 17:00:00 for 15 minute reading intervals and quantity units & kWh as MJ', async () => {
// Use predefined unit and conversion data
Expand Down