Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added maps to preferences #666

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Conversation

jina2k
Copy link
Contributor

@jina2k jina2k commented Nov 8, 2021

Description

Fixes #573

Type of change

  • Note merging this changes the node modules
  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request

Limitations

I have created a migrations folder with the relevant files to move to 0.7.1 as a step before 0.8.0. Documentation needs to be updated where there is an issue of opening localhost:3000 and seeing default map be "displayed" where it shows a blank image (occurs every time browser is reopened). Not that big of an issue as users can reload the page or click a random meter and it will correct itself.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works as desired and is good work. Just need to clean up the migration code (unless you show the current way works).

Also, would you like to open a new issue on the blank map or do you want someone else to do that? It just needs to be looked at sometime.

@jina2k
Copy link
Contributor Author

jina2k commented Nov 13, 2021

The code works as desired and is good work. Just need to clean up the migration code (unless you show the current way works).

Also, would you like to open a new issue on the blank map or do you want someone else to do that? It just needs to be looked at sometime.

Someone else can open an issue for now, I will work on the group page in the meantime

- This makes the alter of graph_type work with migration transactions.
- Moves index.js into proper directory.
@huss
Copy link
Member

huss commented Nov 15, 2021

The code works as desired and is good work. Just need to clean up the migration code (unless you show the current way works).
Also, would you like to open a new issue on the blank map or do you want someone else to do that? It just needs to be looked at sometime.

Someone else can open an issue for now, I will work on the group page in the meantime

I opened issue #667 to address this.

@huss huss merged commit d93a013 into OpenEnergyDashboard:development Nov 15, 2021
@huss huss added this to the 0.8 release milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to make maps the default graphic
2 participants