Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentions of Babel and other small fixes #59

Closed

Conversation

hyperupcall
Copy link

As noted in OpenEnergyDashboard/OED#1248, this updates the documentation for the removal of Babel.

@hyperupcall hyperupcall force-pushed the hyperupcall-docs-updates branch from ec109f2 to 56eb7a2 Compare June 10, 2024 18:03
@huss
Copy link
Member

huss commented Sep 1, 2024

My sincere apologies to @hyperupcall for this having sat for so long. I'm very sorry that I lost track of it during the website update. I've now merged in your changes with those and it all seems fine. This involved porting your changes to the new files. Unfortunately, I don't have the right to push to your branch to update the PR. Would you be willing to grant me that permission or do you know another way short of creating a new PR? Thanks for all your efforts.

@hyperupcall
Copy link
Author

@huss No worries! I think making a new PR is probably easiest if there were major changes - this PR wasn't that big anyways. Should I make my new changes against gh-pages or main?

@huss
Copy link
Member

huss commented Sep 5, 2024

@hyperupcall My understanding is I will do a new PR for these changes (let me know if I have it wrong).

As for other changes, they should be made on main. I have not yet posted the new directions for web pages (since it may still be evolving) but we are using Jekyll to take main to create gh-pages. (The automated build is not working if anyone feels like fixing that - I have some info on it.) Thus, main has all the content and gh-pages are the deployment but still in the repo to keep the complete history (at least until automated). I'm happy to take any changes in main and create the new version of gh-pages. Thanks for asking and your efforts.

@hyperupcall
Copy link
Author

@hyperupcall My understanding is I will do a new PR for these changes (let me know if I have it wrong).

@huss Ahh I misunderstood, so you'll make a new PR for the new changes. Sounds good to me!

As for other changes, they should be made on main. I have not yet posted the new directions for web pages (since it may still be evolving) but we are using Jekyll to take main to create gh-pages. (The automated build is not working if anyone feels like fixing that - I have some info on it.) Thus, main has all the content and gh-pages are the deployment but still in the repo to keep the complete history (at least until automated). I'm happy to take any changes in main and create the new version of gh-pages. Thanks for asking and your efforts.

Thanks, I'll keep that in mind;

huss added a commit to huss/OpenEnergyDashboard.github.io that referenced this pull request Oct 9, 2024
These were from @hyperupcall in PR OpenEnergyDashboard#59 and being
included in the new website design.
@huss
Copy link
Member

huss commented Oct 9, 2024

Many thanks to @hyperupcall for these changes. I have merged them into the staged (but not yet deployed) update to the website. Given this, this PR is no longer needed.

@huss huss closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants