Skip to content

Commit

Permalink
remove error prone code - full type hints not supported by python 3.8…
Browse files Browse the repository at this point in the history
… and this triggers errors in the OEP CI
  • Loading branch information
jh-RLI committed Nov 29, 2022
1 parent b819ca1 commit 12465bd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/omi/dialects/oep/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def parse_date_or_none(x, *args, **kwargs):


def create_report_json(
error_data: list[dict],
error_data, # type list[dict]
save_at: pathlib.Path = "reports/",
filename: str = "report.json",
):
Expand Down Expand Up @@ -795,7 +795,7 @@ def parse_from_string(
)

def get_any_value_not_none(
self, element: dict, keys: list[str], get_return_default=None
self, element: dict, keys, get_return_default=None #keys: list[str] - reove as not support by py3.8
):
"""
Get the value for a key in a dict - but try multiple key names, in
Expand Down

0 comments on commit 12465bd

Please sign in to comment.