Skip to content

Commit

Permalink
Merge branch 'dev' into feature-1865-change-energy-amount-lable
Browse files Browse the repository at this point in the history
  • Loading branch information
madbkr authored Oct 17, 2024
2 parents 4aa0da9 + 7dfc0ff commit 5ce96ba
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/automated-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-python@v4
with:
python-version: '3.7'
python-version: '3.7.17'
architecture: x64
- uses: actions/setup-java@v2
with:
Expand Down Expand Up @@ -101,4 +101,4 @@ jobs:
filename: open_energy_ontology__${{ env.BRANCH }}.json
label: CQ Coverage
message: ${{ env.COVERAGE }}
color: green
color: green
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/
- replace term tracker item with term tracker annotation (#1922, #1923)
- replace has bearer with characteristic of (#1928)
- energy amount value / energy value (#1941)
- rework contributing and readme file (#1937)
- rework contributing and readme file (#1937, #1946)
- time stamp (#1944)

### Obsoletion
Expand Down
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Please read the [OEO best practices](https://github.com/OpenEnergyPlatform/ontol
| 🔶 <br/>*orange diamond* | git | keeping code in sync between your PC and online-repository |
| 🐙 <br/>*octopus* | github | discussions and reviews |
| 📙 <br/>*orange book* | protégé | changing the ontology |
| 📝 <br/>*memo* | text editor | changing the ontology as well as other files
| 📝 <br/>*memo* | text editor | changing the ontology as well as other files |

### Conventions for git and GitHub

Expand All @@ -61,11 +61,11 @@ Add the issue number where you describe, discuss and document your development.

**short-description**

Describe shortly what the branch is about. Avoid long and short descriptive names for branches, 2-4 words are optimal.
Describe shortly what the branch is about. Avoid descriptive names for branches that are either too short or too long, 2-4 words are optimal.

Other hints:
- Separate words with `-` (minus)
- Do not put your name to the branch name, it's a collaborative project
- Do not add your name to the branch name, it's a collaborative project
- Avoid using numbers only
- Branch names should be precise and informative
- Avoid using capital letters
Expand All @@ -88,7 +88,6 @@ git commit --amend
```
to edit the commit message of your latest commit (provided it is not already pushed on the remote server). <br>
With `--amend` you can even add/modify changes to the commit.
|


### Workflow
Expand All @@ -114,7 +113,8 @@ by [Vincent Driessen](https://nvie.com/posts/a-successful-git-branching-model/).

[Assign a project](https://help.github.com/en/github/managing-your-work-on-github/adding-issues-and-pull-requests-to-a-project-board#adding-issues-and-pull-requests-to-a-project-board-from-the-sidebar) (default "Issues") to the issue

Discussion about the implementation should take place within the issue. **Important**: Please discuss the proposal within the issue thread **before** starting to work on a solution. <br>
Discussion about the implementation should take place within the issue. <br> <br>
**Important**: Please discuss the proposal within the issue thread **before** starting to work on a solution. <br>
For minor changes, which include small changes to improve clarity of definitions and the addition of clarifying annotations, at least one other person from the project team should agree to the proposed change before it is implemented. <br>
For major changes, which include adding new entities and restructuring the ontology, at least two other members of the project team need to agree to the change before it is implemented, which should include at least one domain expert and at least one ontology expert. <br>
Issues which are contentious, for which it is difficult to reach agreement, should be added to the agenda of the next ontology working group teleconference for discussion to reach agreement amongst the full working group. Subsequent to such discussion, the issue's first thread should be updated with a documented record of the conclusions reached.
Expand Down Expand Up @@ -163,7 +163,7 @@ by [Vincent Driessen](https://nvie.com/posts/a-successful-git-branching-model/).
```
If your branch does not exist on the remote server yet, git will provide you with instructions, simply follow them.

**Hint:** You can create a draft pull request directly after your first commit 🐙, see 7.). <br>
**Hint:** You can create a draft pull request directly after your first commit 🐙, see 7). <br>
Then you get the pull request number and 📙 implement the [term tracker annotations](https://github.com/OpenEnergyPlatform/ontology/wiki/Term-Tracker-Annotation) in Protégé. Only after finishing the implementations you can assign reviewers and thus change the state of the PR. Using that workflow, it is clear whether a PR is actually ready for review.

6. 🐙 Make sure that all automated tests are successful. This will be indicated by a green or red icon next to your most recent commit. In case an error occured that you don't know how to solve, write a comment in the PR and ask for help from the ontology-expert-team.
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ Wiki articles that you would be most helpflul to a beginner are:
- [Use Protégé to Change the Ontology](https://github.com/OpenEnergyPlatform/ontology/wiki/How-to-use-prot%C3%A9g%C3%A9-to-change-the-ontology)
- [Term Tracker Annotation](https://github.com/OpenEnergyPlatform/ontology/wiki/Term-Tracker-Annotation)
<br>
... as well as the [CONTRIBUTING.md](https://github.com/OpenEnergyPlatform/ontology/blob/dev/CONTRIBUTING.md).

... as well as the [CONTRIBUTING.md](https://github.com/OpenEnergyPlatform/ontology/blob/dev/CONTRIBUTING.md)


## Teams
Expand Down

0 comments on commit 5ce96ba

Please sign in to comment.