Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units with prefixes and composed units #1402

Closed
1 task done
chrwm opened this issue Nov 16, 2022 · 11 comments · Fixed by #1835
Closed
1 task done

Units with prefixes and composed units #1402

chrwm opened this issue Nov 16, 2022 · 11 comments · Fixed by #1835
Assignees
Labels
[A] new term Including new term(s) in the ontology composed module oeo dev meeting Discuss issue at oeo dev meeting

Comments

@chrwm
Copy link
Member

chrwm commented Nov 16, 2022

Description of the issue

When annotating data in practice some units might not be present in the OEO. This could be specific units, as cited below, or units that appear more frequently in our domain, such as kW, MW, GW - which are all not present in the OEO yet.

I understand the units are imported from the "Unit Ontology" and find it strange that some units have more detailed prefixes, e.g. mass unit -> picogram, gram, kilogram, ..., than others.

Unit with prefix annotation: If units have a prefix such as kilo, giga etc. it is usually appended to the unit with k-, g- etc. and this way a part of the unit. Sometimes it happens that there is column with a certain measurement magnitude e.g., column “passengers (thousand)”. How should the “thousand” in such a case be handled? As a kilo to the unit like a normal prefix or as a kilo-concept to the parameter reference?

Originally posted by @lumi321 in OpenEnergyPlatform/oeplatform#1107 (comment)

Composed and rather rare units I'd consider to implement on demand in the future.

Ideas of solution

Add units that are frequently used in domain but still missing in OEO, such as

  • kilowatt
  • megawatt
  • gigawatt
  • ...

TODO check rest of UO to complete list

Workflow checklist

  • I am aware of the workflow for this repository
@stap-m
Copy link
Contributor

stap-m commented Nov 17, 2022

Composed and rather rare units I'd consider to implement on demand in the future.

But implementing on demand might be slow. We should at least discuss how to deal with composed units in general, e.g. €/MW.

@chrwm chrwm self-assigned this Nov 17, 2022
@chrwm chrwm added the [A] new term Including new term(s) in the ontology label Nov 17, 2022
@l-emele l-emele added this to the oeo-release-1.13.0 milestone Nov 18, 2022
@l-emele l-emele added the oeo dev meeting Discuss issue at oeo dev meeting label Nov 18, 2022
@l-emele
Copy link
Contributor

l-emele commented Nov 18, 2022

This is a very important issue and we probably won't solve it as issue discussion. So I put it on the agenda for the next oeo dev meeting. https://etherpad.wikimedia.org/p/oeo-dev-49

@lumi321
Copy link
Contributor

lumi321 commented Nov 18, 2022

Related to this is issue OpenEnergyPlatform/oeo-extended#10 about specific units.

@l-emele
Copy link
Contributor

l-emele commented Jan 26, 2023

We had yesterday the physical meeting on composed concepts. We made progress, but do not have a final solution. Thus I postpone this issue.

@stap-m
Copy link
Contributor

stap-m commented Nov 28, 2023

Related to #1690

@l-emele
Copy link
Contributor

l-emele commented Feb 23, 2024

@chrwm : I suggest to close this issue now:

If you agree, please close this issue.

@stap-m stap-m closed this as completed Feb 23, 2024
@stap-m stap-m reopened this Mar 20, 2024
@stap-m
Copy link
Contributor

stap-m commented Mar 20, 2024

I reopen this issue. We need a relation between units and prefixes. Either we use 'has part' or create a subproperty 'has prefix':
For example: Gigawatt EquivalentTo watt and 'has prefix' some giga
This is important for oeo-extended as well.

@l-emele
Copy link
Contributor

l-emele commented Mar 20, 2024

The units ontology has the object property has_prefix. My understanding was that this will be imported, but seemingly we forgot this in #1690

@UStucky
Copy link
Contributor

UStucky commented Mar 21, 2024

For an example of quantity-related classes (OO software) see #1510

@stap-m
Copy link
Contributor

stap-m commented Apr 16, 2024

The units ontology has the object property has_prefix. My understanding was that this will be imported, but seemingly we forgot this in #1690

The thing is that the IRI of has_prefix http://purl.obolibrary.org/obo/has_prefix leads to an error...

@stap-m
Copy link
Contributor

stap-m commented Apr 16, 2024

I'd propose to create a proper oeo relation has prefix and add the "may be identical to" annotation to relate to the above mentioned obo relation. A def could be:
A relation between a unit and a prefix that indicate the magnitude of the unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology composed module oeo dev meeting Discuss issue at oeo dev meeting
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants