Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make boiler an equivalent class #1570

Closed
5 tasks
stap-m opened this issue Jun 1, 2023 · 3 comments · Fixed by #1771
Closed
5 tasks

make boiler an equivalent class #1570

stap-m opened this issue Jun 1, 2023 · 3 comments · Fixed by #1771
Assignees
Labels
[B] restructure Restructuring existing parts of the ontology bug Something isn't working good first issue Good for newcomers ready for implementation

Comments

@stap-m
Copy link
Contributor

stap-m commented Jun 1, 2023

Description of the issue

grafik

Combution-based heater1 and electric heater2 can also be boilers when heating a fluid. Thus, boiler should be an equivalent class.

Ideas of solution

Make equivalent class with the axiom heater and (uses some fluid)

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words

Footnotes

  1. A combustion-based heater is a heater that increases the thermal energy using combustion.

  2. An electrical heater is a heater that increases the thermal energy using electric energy.

@stap-m stap-m added bug Something isn't working [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Jun 1, 2023
@stap-m stap-m added this to the oeo-release 1.16.0 milestone Jun 1, 2023
@l-emele
Copy link
Contributor

l-emele commented Jun 1, 2023

I agree with making this an equivalent class, however I doubt whether heater and (uses some fluid) is specific enough to catch increases the thermal energy of fluids.

@stap-m
Copy link
Contributor Author

stap-m commented Jun 1, 2023

I agree with making this an equivalent class, however I doubt whether heater and (uses some fluid) is specific enough to catch increases the thermal energy of fluids.

Yep, I had the same thought. Probably related to #1534

@stap-m
Copy link
Contributor Author

stap-m commented Oct 25, 2023

Make equivalent class with the axiom heater and (uses some fluid)

We now have heating process which can be applied. What about:
boiler EquivalentTo: heater and 'participates in' some (heating and 'has participant' some fluid)

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Oct 25, 2023
viktorwichern added a commit that referenced this issue Nov 29, 2023
…iler-equivalent

make boiler an equivalent class #1570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology bug Something isn't working good first issue Good for newcomers ready for implementation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants