Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add something like service product or non-material good #1584

Closed
5 tasks
l-emele opened this issue Jun 15, 2023 · 6 comments · Fixed by #1748
Closed
5 tasks

Add something like service product or non-material good #1584

l-emele opened this issue Jun 15, 2023 · 6 comments · Fixed by #1748
Labels
[A] new term Including new term(s) in the ontology tricky issue Issues that are not easily to solve and needs thinking outside the box

Comments

@l-emele
Copy link
Contributor

l-emele commented Jun 15, 2023

Description of the issue

Discussions (e.g. in #1487 and #1239) have shown that we sometimes have to aggregate good and service which is difficult as good is a continuant and service is an occurent. Services are associated with some very abstract "results" that have the added value of the service, this could be something like a service product or a non-material good.

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@l-emele l-emele added [A] new term Including new term(s) in the ontology To do Issues that haven't got discussed yet labels Jun 15, 2023
@l-emele l-emele added this to the oeo-release 1.16.0 milestone Jun 15, 2023
@l-emele l-emele added the tricky issue Issues that are not easily to solve and needs thinking outside the box label Jul 13, 2023
@viktorwichern
Copy link
Contributor

viktorwichern commented Oct 27, 2023

My proposal is to handle this similar to how good is implemented, we define a role and an equivalent class.

service product role
definition: A service product role is the role of an immaterial entity that is the result of a service, and whose value is determined by the value and the costs of the service.

service product
definition: A service product is an immaterial entity that has the service product role.

@l-emele
Copy link
Contributor Author

l-emele commented Oct 30, 2023

I am fine with this proposal.

@viktorwichern
Copy link
Contributor

@stap-m @nelekoehler @fabianneuhaus any second opinions before I implement?

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Oct 30, 2023
@stap-m
Copy link
Contributor

stap-m commented Nov 1, 2023

A service product role is the role of an immaterial entity that is the result of a service process, and whose value is determined by the value and the costs of the service.
I added the word "process" to the definition to underline the difference between service and service product.

@stap-m
Copy link
Contributor

stap-m commented Nov 13, 2023

No comments for 2 weeks. I think you can go ahead with implementing @viktorwichern

@viktorwichern
Copy link
Contributor

No comments for 2 weeks. I think you can go ahead with implementing @viktorwichern

I did in PR #1748

viktorwichern added a commit that referenced this issue Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology tricky issue Issues that are not easily to solve and needs thinking outside the box
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants